Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump the everything-else group with 15 updates #1747

Closed
wants to merge 2 commits into from
Closed

chore(deps): Bump the everything-else group with 15 updates #1747

wants to merge 2 commits into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 8, 2024 •
edited
Loading

Bumps the everything-else group with 15 updates:

Package From To
github.com/btcsuite/btcd/btcutil 1.1.3 1.1.5
github.com/gdamore/tcell/v2 2.6.0 2.7.4
github.com/gnolang/goleveldb 0.0.9 0.1.0
github.com/golang/protobuf 1.5.3 1.5.4
github.com/rogpeppe/go-internal 1.11.0 1.12.0
github.com/stretchr/testify 1.8.4 1.9.0
go.etcd.io/bbolt 1.3.8 1.3.9
go.uber.org/multierr 1.10.0 1.11.0
go.uber.org/zap 1.26.0 1.27.0
golang.org/x/crypto 0.19.0 0.21.0
golang.org/x/mod 0.15.0 0.16.0
golang.org/x/net 0.21.0 0.22.0
golang.org/x/term 0.17.0 0.18.0
golang.org/x/tools 0.18.0 0.19.0
google.golang.org/protobuf 1.31.0 1.33.0

Updates github.com/btcsuite/btcd/btcutil from 1.1.3 to 1.1.5

Commits
  • 790c570 Merge pull request #2081 from Roasbeef/dont-serialize-tx-for-txhash
  • e102a81 btcutil: add benchmarks for Hash + WitnessHash
  • 56de9ca btcutil: align new serialization caching logic w/ codebase style
  • 8766bfd Merge pull request #2071 from guggero/integration-harness-fixes
  • 7644d14 blockchain: fix compilation issues with 32bit systems
  • dd5f3bd rpctest: make test TCP ports unique per process
  • d33ac28 rpctest: add more context to errors
  • 323cf1e rpctest: fix test node directory
  • 6e7680a rpctest: fix formatting
  • 83605e4 btcutil: reuse serialized tx during TxHash
  • Additional commits viewable in compare view

Updates github.com/gdamore/tcell/v2 from 2.6.0 to 2.7.4

Release notes

Sourced from github.com/gdamore/tcell/v2's releases.

Version 2.7.4 Bug Fix Release

This release fixes a problem with restoring cursor location properly on Windows.

It also includes a new stress test for your terminal (FPS monitor) contributed by @​Bios-Marcel

Version 2.7.3 Bug Fix Release

This release just updates the terminfo data using current data from Ubuntu 24.04 (Noble). It fixes a regression where we dropped some capabilities including StrikeThrough for some terminals.

Version 2.7.2 Improvement Release

This release does not add new APIs, but it does improve the functionality of tcell on Windows, and provides an "undocumented" feature for managing the alternate screen buffer.

  • Windows uses VT mode output everywhere except on ConEmu (because VT output mode on ConEmu is borked for colors)
    • The TCELL_VTMODE environment variable can be set to "enable" or "disable" to force attempting to use (or not) this mode.
  • Windows now uses the alternate screen buffer by default, and preserves the original screen content
  • Use of the alternate screen can be disabled setting the TCELL_ALTSCREEN environment variable to "disable".
  • If the alternate screen is disabled in that fashion, we will not clear the screen either. This is an experimental way to preserve the output from a tcell application on exit or suspend. Feedback on this would be appreciated.

The specific environment variables listed here are not considered part of the Tcell API, and their presence and meaning may change without notice at any time. Please consider them experimental and let us know whether these are useful or not.

Version 2.7.1 Bug Fix Release

This release fixes a few problems, and also adds a feature that was missing on Windows.

  • Fix for disappearing wide (including emoji) characters on Windows (#621)
  • Fix for wide characters causing scrolling when on bottom line on UNIX/Linux (#679)
  • Fix for PollEvent returning nil on screen Suspend (regression) (#687)
  • Fix for AltGr modifiers on Windows, contributed by stk [email protected]

Additionally:

  • Support for the termite (defunct) was removed from the built-in terminals. The fallback support by parsing terminfo still works. The termite project is now abandoned and the project advises users to use Alacritty (which is natively supported in tcell.)
  • Support for focus event reporting was added for Windows
  • The Views API no longer uses deprecated tcell functions internally (#682)

Version 2.7.0 Feature Release

Significant changes in this release:

  • Introduced ColorNone which can be used in a style to avoid changing the existing foreground or background color.
  • Refactored the screen logic to provide better code reuse and facilitate extending the Screen API in future releases. (This changes internal APIs only)
  • Color grew some methods to report a String() (color name) or CSS() (color hex string in CSS style)
  • LockRegion() and Tty API changes from Tim Culverhouse [email protected] in support of Sixel coexistence. This does not itself provide support for Sixel graphics, but it allows tcell applications to be used with other sixel graphics libraries.
  • Mouse focus reporting (see EnableFocus(), DisableFocus(), and EventFocus) courtesy of stk [email protected] (I also added support for focus reporting in the WASM terminal.) Windows console does not report this yet.

The refactoring in particular will enable some further improvements. Also, we added more test cases and coverage. While much of tcell remains uncovered by formal testing, every improvement here is welcome.

I expect to follow up with another release soon -- things I'm hoping for are gpm mouse support for the linux console (oft-requested), refactoring wide character support to fix some long standing bugs, and convenience methods to apply content or style changes to a rectangular region of the screen. In the meantime, I hope you enjoy this release!

Fixes (relative to 2.6.0)

  • mouse demo: fix crash when multiple buttons pressed together

... (truncated)

Commits
  • d1364d5 windows: restore cursor location correctly
  • b02dac3 fix stress demo (race on close)
  • 2c305c0 Add little stresser that just draws as much 'random' stuff as possible
  • de40850 terminfo: regenerate all entries
  • 6c95e8d Try not to clear screen on Windows if TCELL_ALTSCREEN=disable
  • 6984e25 Allow use of TCELL_ALTSCREEN=disable to disable alternate screen.
  • 552bf3c windows: Use alt screen by default (supress with TCELL_ALTSCREEN=disable)
  • 5a591d4 Use automargin disable
  • f6c43a3 ConEmu fixes - we cannot go to 24-bit mode on that yet.
  • cd0fe98 Windows: enable VT mode output by default
  • Additional commits viewable in compare view

Updates github.com/gnolang/goleveldb from 0.0.9 to 0.1.0

Release notes

Sourced from github.com/gnolang/goleveldb's releases.

v0.1.0

  • Added js+wasm target
  • Renamed to gnolang/goleveldb
Commits
  • 4512381 feat: add js+wasm target (#2)
  • 1ca8c4d chore: rename to gnolang/goleveldb (#1)
  • 126854a leveldb: fix table file leaks when manifest is rotated (#409)
  • 64ee559 Add golang ci lint to CI (#350)
  • 678c1e8 iterator: use heap to accelerate mergedIterator
  • 9ab5d34 cache: speed-up TestCacheMap
  • 686510c cache: TestCacheMap: wait grow-shrink goroutine to stop
  • 467c5cb travis: switch to short test
  • 75fe519 use nil []byte instead of zero len []byte
  • 943eb65 expose cache statistic in DBStats
  • Additional commits viewable in compare view

Updates github.com/golang/protobuf from 1.5.3 to 1.5.4

Release notes

Sourced from github.com/golang/protobuf's releases.

v1.5.4

Notable changes

  • update descriptor.proto to latest version
Commits

Updates github.com/rogpeppe/go-internal from 1.11.0 to 1.12.0

Commits
  • 2c88e7f robustio: copy from cmd/go/internal/robustio (#239)
  • fa6a31e testscript: add TestScript.Name
  • 0bcf77f testscript,goproxytest: use filepath.WalkDir
  • 32ae337 testscript: propagate GORACE like we already do with GOCOVERDIR
  • b6a9d8b all: add Go 1.21, drop Go 1.19
  • 3fbe0b6 testscript: skip pty test on macOS due to golang/go#61779
  • e748a67 testscript: add ttyin/ttyout commands
  • See full diff in compare view

Updates github.com/stretchr/testify from 1.8.4 to 1.9.0

Release notes

Sourced from github.com/stretchr/testify's releases.

v1.9.0

What's Changed

... (truncated)

Commits
  • bb548d0 Merge pull request #1552 from stretchr/dependabot/go_modules/github.com/stret...
  • 814075f build(deps): bump github.com/stretchr/objx from 0.5.1 to 0.5.2
  • e045612 Merge pull request #1339 from bogdandrutu/uintptr
  • 5b6926d Merge pull request #1385 from hslatman/not-implements
  • 9f97d67 Merge pull request #1550 from stretchr/release-notes
  • bcb0d3f Include the auto-release notes in releases
  • fb770f8 Merge pull request #1247 from ccoVeille/typos
  • 85d8bb6 fix typos in comments, tests and github templates
  • e2741fa Merge pull request #1548 from arjunmahishi/msgAndArgs
  • 6e59f20 http_assertions: assert that the msgAndArgs actually works in tests
  • Additional commits viewable in compare view

Updates go.etcd.io/bbolt from 1.3.8 to 1.3.9

Release notes

Sourced from go.etcd.io/bbolt's releases.

v1.3.9

See the CHANGELOG for more details.

Commits
  • 50aef26 Merge pull request #683 from Elbehery/backport_fix_cli_panics
  • 25dacb3 fix cli cmds panics
  • e102fcf Merge pull request #639 from fuweid/cp-copy-key-before-seek
  • fabe2fb *: copy key before comparing during CreateBucket
  • 50ddad0 bucket: copy key before Put
  • b3bdd17 tests/robustness: add issue72 reproducer
  • d520aaa *: introduce failpoint beforeBucketPut
  • 0a521c0 bucket: allow to allocate key on stack in Put()
  • defa564 Merge pull request #600 from Richabanker/release-1.3
  • fe23f52 Backport concurrent_test.go to release-1.3 branch
  • See full diff in compare view

Updates go.uber.org/multierr from 1.10.0 to 1.11.0

Release notes

Sourced from go.uber.org/multierr's releases.

v1.11.0

  • Errors now supports any error that implements multiple-error interface.
  • Add Every function to allow checking if all errors in the chain satisfies errors.Is against the target error.
Changelog

Sourced from go.uber.org/multierr's changelog.

v1.11.0 (2023-03-28)

  • Errors now supports any error that implements multiple-error interface.
  • Add Every function to allow checking if all errors in the chain satisfies errors.Is against the target error.
Commits

Updates go.uber.org/zap from 1.26.0 to 1.27.0

Release notes

Sourced from go.uber.org/zap's releases.

v1.27.0

Enhancements:

  • #1378[]: Add WithLazy method for SugaredLogger.
  • #1399[]: zaptest: Add NewTestingWriter for customizing TestingWriter with more flexibility than NewLogger.
  • #1406[]: Add Log, Logw, Logln methods for SugaredLogger.
  • #1416[]: Add WithPanicHook option for testing panic logs.

Thanks to @​defval, @​dimmo, @​arxeiss, and @​MKrupauskas for their contributions to this release.

#1378: uber-go/zap#1378 #1399: uber-go/zap#1399 #1406: uber-go/zap#1406 #1416: uber-go/zap#1416

Changelog

Sourced from go.uber.org/zap's changelog.

1.27.0 (20 Feb 2024)

Enhancements:

  • #1378[]: Add WithLazy method for SugaredLogger.
  • #1399[]: zaptest: Add NewTestingWriter for customizing TestingWriter with more flexibility than NewLogger.
  • #1406[]: Add Log, Logw, Logln methods for SugaredLogger.
  • #1416[]: Add WithPanicHook option for testing panic logs.

Thanks to @​defval, @​dimmo, @​arxeiss, and @​MKrupauskas for their contributions to this release.

#1378: uber-go/zap#1378 #1399: uber-go/zap#1399 #1406: uber-go/zap#1406 #1416: uber-go/zap#1416

Commits

Updates golang.org/x/crypto from 0.19.0 to 0.21.0

Commits
  • 7067223 go.mod: update golang.org/x dependencies
  • 0d2316b ssh/test: work around for TestCiphers failures on macOS
  • 0aab8d0 all: update go.mod x/net dependency
  • 5bead59 ocsp: don't use iota for externally defined constants
  • 1a86580 x/crypto/internal/poly1305: improve sum_ppc64le.s
  • 1c981e6 ssh/test: don't use DSA keys in integrations tests, update test RSA key
  • 62c9f17 x509roots/nss: manually exclude a confusingly constrained root
  • See full diff in compare view

Updates golang.org/x/mod from 0.15.0 to 0.16.0

Commits
  • 766dc5d modfile: use new go version string format in WorkFile.add error
  • See full diff in compare view

Updates golang.org/x/net from 0.21.0 to 0.22.0

Commits
  • 7ee34a0 go.mod: update golang.org/x dependencies
  • c289c7a websocket: re-add documentation for DialConfig
  • 9fb4a8c http2: send an error of FLOW_CONTROL_ERROR when exceed the maximum octets
  • 3dfd003 websocket: add support for dialing with context
  • fa11427 quic: move package out of internal
  • 591be7f quic: fix UDP on big-endian Linux, tests on various architectures
  • 34cc446 quic: temporarily disable networking tests failing on various platforms
  • 4bdc6df quic: expand package docs, and document Stream
  • 22cbde9 quic: set ServerName in client connection TLSConfig
  • 57e4cc7 quic: handle PATH_CHALLENGE and PATH_RESPONSE frames
  • Additional commits viewable in compare view

Updates golang.org/x/term from 0.17.0 to 0.18.0

Commits

Updates golang.org/x/tools from 0.18.0 to 0.19.0

Commits
  • 7656c4c go.mod: update golang.org/x dependencies
  • 5bf7d00 cmd/callgraph: add 'posn' template helper
  • 283fce2 x/tools: drop go1.18 support
  • 7f348c7 internal/versions: updates the meaning of FileVersions.
  • 38b0e9b x/tools: add explicit Unalias operations
  • a6c03c8 x/tools: update telemetry import (new Start API)
  • 1f7dbdf gopls/internal/cache: add debug assertions for bug report
  • 4d4e802 gopls/doc: address additional comments on workspace.md
  • abe5874 gopls/internal/analysis: add fill switch cases code action
  • fc70354 gopls/internal/test: add test for NPE in control flow highlighting
  • Additional commits viewable in compare view

Updates google.golang.org/protobuf from 1.31.0 to 1.33.0

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

@dependabot dependabot bot requested a review from a team as a code owner March 8, 2024 21:35
@dependabot dependabot bot added the dependencies Update to the dependencies label Mar 8, 2024
@dependabot dependabot bot requested a review from moul March 8, 2024 21:35
@dependabot dependabot bot requested review from a team and gfanton as code owners March 8, 2024 21:36
@zivkovicmilos
Copy link
Member

zivkovicmilos commented Mar 8, 2024 •
edited
Loading

@ajnavarro @thehowl @gfanton
Any ideas why the testing suite for the db tests is failing?

EDIT:
Actually, just ignore this question, I don't actually care after seeing #1714

@ajnavarro
Copy link
Contributor

@dependabot rebase

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 14, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@ajnavarro
Copy link
Contributor

@dependabot recreate

@dependabot
chore(deps): Bump the everything-else group with 15 updates
78c9fca 
Bumps the everything-else group with 15 updates:

| Package | From | To |
| --- | --- | --- |
| [github.com/btcsuite/btcd/btcutil](https://github.com/btcsuite/btcd) | `1.1.3` | `1.1.5` |
| [github.com/gdamore/tcell/v2](https://github.com/gdamore/tcell) | `2.6.0` | `2.7.4` |
| [github.com/gnolang/goleveldb](https://github.com/gnolang/goleveldb) | `0.0.9` | `0.1.0` |
| [github.com/golang/protobuf](https://github.com/golang/protobuf) | `1.5.3` | `1.5.4` |
| [github.com/rogpeppe/go-internal](https://github.com/rogpeppe/go-internal) | `1.11.0` | `1.12.0` |
| [github.com/stretchr/testify](https://github.com/stretchr/testify) | `1.8.4` | `1.9.0` |
| [go.etcd.io/bbolt](https://github.com/etcd-io/bbolt) | `1.3.8` | `1.3.9` |
| [go.uber.org/multierr](https://github.com/uber-go/multierr) | `1.10.0` | `1.11.0` |
| [go.uber.org/zap](https://github.com/uber-go/zap) | `1.26.0` | `1.27.0` |
| [golang.org/x/crypto](https://github.com/golang/crypto) | `0.19.0` | `0.21.0` |
| [golang.org/x/mod](https://github.com/golang/mod) | `0.15.0` | `0.16.0` |
| [golang.org/x/net](https://github.com/golang/net) | `0.21.0` | `0.22.0` |
| [golang.org/x/term](https://github.com/golang/term) | `0.17.0` | `0.18.0` |
| [golang.org/x/tools](https://github.com/golang/tools) | `0.18.0` | `0.19.0` |
| google.golang.org/protobuf | `1.31.0` | `1.33.0` |


Updates `github.com/btcsuite/btcd/btcutil` from 1.1.3 to 1.1.5
- [Release notes](https://github.com/btcsuite/btcd/releases)
- [Changelog](https://github.com/btcsuite/btcd/blob/master/CHANGES)
- [Commits](btcsuite/btcd@btcutil/v1.1.3...btcutil/v1.1.5)

Updates `github.com/gdamore/tcell/v2` from 2.6.0 to 2.7.4
- [Release notes](https://github.com/gdamore/tcell/releases)
- [Changelog](https://github.com/gdamore/tcell/blob/main/CHANGESv2.md)
- [Commits](gdamore/tcell@v2.6.0...v2.7.4)

Updates `github.com/gnolang/goleveldb` from 0.0.9 to 0.1.0
- [Release notes](https://github.com/gnolang/goleveldb/releases)
- [Commits](https://github.com/gnolang/goleveldb/compare/v0.0.9...v0.1.0)

Updates `github.com/golang/protobuf` from 1.5.3 to 1.5.4
- [Release notes](https://github.com/golang/protobuf/releases)
- [Commits](golang/protobuf@v1.5.3...v1.5.4)

Updates `github.com/rogpeppe/go-internal` from 1.11.0 to 1.12.0
- [Release notes](https://github.com/rogpeppe/go-internal/releases)
- [Commits](rogpeppe/go-internal@v1.11.0...v1.12.0)

Updates `github.com/stretchr/testify` from 1.8.4 to 1.9.0
- [Release notes](https://github.com/stretchr/testify/releases)
- [Commits](stretchr/testify@v1.8.4...v1.9.0)

Updates `go.etcd.io/bbolt` from 1.3.8 to 1.3.9
- [Release notes](https://github.com/etcd-io/bbolt/releases)
- [Commits](etcd-io/bbolt@v1.3.8...v1.3.9)

Updates `go.uber.org/multierr` from 1.10.0 to 1.11.0
- [Release notes](https://github.com/uber-go/multierr/releases)
- [Changelog](https://github.com/uber-go/multierr/blob/master/CHANGELOG.md)
- [Commits](uber-go/multierr@v1.10.0...v1.11.0)

Updates `go.uber.org/zap` from 1.26.0 to 1.27.0
- [Release notes](https://github.com/uber-go/zap/releases)
- [Changelog](https://github.com/uber-go/zap/blob/master/CHANGELOG.md)
- [Commits](uber-go/zap@v1.26.0...v1.27.0)

Updates `golang.org/x/crypto` from 0.19.0 to 0.21.0
- [Commits](golang/crypto@v0.19.0...v0.21.0)

Updates `golang.org/x/mod` from 0.15.0 to 0.16.0
- [Commits](golang/mod@v0.15.0...v0.16.0)

Updates `golang.org/x/net` from 0.21.0 to 0.22.0
- [Commits](golang/net@v0.21.0...v0.22.0)

Updates `golang.org/x/term` from 0.17.0 to 0.18.0
- [Commits](golang/term@v0.17.0...v0.18.0)

Updates `golang.org/x/tools` from 0.18.0 to 0.19.0
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.18.0...v0.19.0)

Updates `google.golang.org/protobuf` from 1.31.0 to 1.33.0

---
updated-dependencies:
- dependency-name: github.com/btcsuite/btcd/btcutil
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: everything-else
- dependency-name: github.com/gdamore/tcell/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: github.com/gnolang/goleveldb
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: github.com/golang/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: everything-else
- dependency-name: github.com/rogpeppe/go-internal
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: github.com/stretchr/testify
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: go.etcd.io/bbolt
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: everything-else
- dependency-name: go.uber.org/multierr
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: go.uber.org/zap
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: golang.org/x/crypto
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: golang.org/x/mod
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: golang.org/x/term
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: everything-else
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot-go_modules-master-everything-else-89d5402123 branch from d3616e5 to 78c9fca Compare March 14, 2024 10:17
@thehowl
Copy link
Member

thehowl commented Mar 14, 2024

Any ideas why the testing suite for the db tests is failing?

@zivkovicmilos this PR updates goleveldb, which apparently in this version changes the behaviour for when a key does not exist: https://github.com/gnolang/gno/actions/runs/8279007909/job/22652531366

    backend_test.go:81: 
        	Error Trace:	/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:81
        	            				/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:90
        	Error:      	Not equal: 
        	            	expected: []byte(nil)
        	            	actual  : []byte{}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,3 @@
        	            	-([]uint8) <nil>
        	            	+([]uint8) {
        	            	+}
        	            	 
        	Test:       	TestBackendsNilKeys/Testing_goleveldb
    backend_test.go:82: 
        	Error Trace:	/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:82
        	            				/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:90
        	Error:      	Not equal: 
        	            	expected: false
        	            	actual  : true
        	Test:       	TestBackendsNilKeys/Testing_goleveldb

likely something has to be changed in our implementation

@zivkovicmilos
Copy link
Member

zivkovicmilos commented Mar 29, 2024 •
edited
Loading

Any ideas why the testing suite for the db tests is failing?

@zivkovicmilos this PR updates goleveldb, which apparently in this version changes the behaviour for when a key does not exist: https://github.com/gnolang/gno/actions/runs/8279007909/job/22652531366

    backend_test.go:81: 
        	Error Trace:	/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:81
        	            				/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:90
        	Error:      	Not equal: 
        	            	expected: []byte(nil)
        	            	actual  : []byte{}
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,2 +1,3 @@
        	            	-([]uint8) <nil>
        	            	+([]uint8) {
        	            	+}
        	            	 
        	Test:       	TestBackendsNilKeys/Testing_goleveldb
    backend_test.go:82: 
        	Error Trace:	/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:82
        	            				/home/runner/work/gno/gno/tm2/pkg/db/backend_test.go:90
        	Error:      	Not equal: 
        	            	expected: false
        	            	actual  : true
        	Test:       	TestBackendsNilKeys/Testing_goleveldb

likely something has to be changed in our implementation

Thank you for looking into it, I'll fix it up 🙏

As you mentioned, this was the problem:
https://github.com/gnolang/goleveldb/commit/75fe51978d5f82f9b62d1025e1d061cb2008c38b

@zivkovicmilos
Copy link
Member

@dependabot ignore github.com/gnolang/goleveldb

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 29, 2024

OK, I won't notify you about github.com/gnolang/goleveldb again, unless you unignore it.

@zivkovicmilos
Copy link
Member

@dependabot recreate

@dependabot Dependabot
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 29, 2024

Looks like these dependencies are updatable in another way, so this is no longer needed.

@dependabot dependabot bot closed this Mar 29, 2024
@dependabot dependabot bot deleted the dependabot-go_modules-master-everything-else-89d5402123 branch March 29, 2024 06:34
@zivkovicmilos zivkovicmilos mentioned this pull request Mar 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@moul moul Awaiting requested review from moul

@gfanton gfanton Awaiting requested review from gfanton

Assignees
No one assigned
Labels
dependencies Update to the dependencies
Projects
💪 Bounties & Worx
Status: Done
🧐 Review Meeting
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zivkovicmilos @ajnavarro @thehowl